Add a family of 14 new string processing nodes by Keavon · Pull Request #4010 · GraphiteEditor/Graphite

Keavon · 2026-04-05T12:38:17Z

Category - Text

Format Number: Formats a number as a string with control over decimal places, separators, fixed decimals, and thousands grouping.
String to Number: Parses a string into a number, with a configurable fallback value.
String Truncate: Clips a string to a max character length, optionally appending a suffix (e.g. …) on truncation.
String Trim: Removes leading and/or trailing whitespace, independently toggleable for start and end.
String Escape: Converts between literal escape sequences (\n, \t, etc.) and their actual control characters, in either direction.
String Reverse: Reverses the character sequence of a string.
String Repeat: Repeats a string N times, with an optional separator and a "Separator Escaping" option.
String Pad: Pads a string to a target length with a fill substring, with start/end targeting and an "Up To" parameter.
String Contains: Checks if a string contains a substring, optionally anchored to the start and/or end.
String Find Index: Returns the index of the first (or last) occurrence of a substring, or -1 if not found.
String Occurrences: Counts occurrences of a substring within a string.
String Join: Joins a list of strings with a separator; the inverse of String Split.

Category - Context

Map String: Iterates over a list of strings, evaluating a mapped node operation for each one (loop construct).
Read String: Reads the current string from inside a Map String loop.

gemini-code-assist

Code Review

This pull request introduces a comprehensive set of string manipulation nodes to the node graph, including functionality for capitalization, joining, padding, repeating, and searching. It also updates the UI to support these nodes, specifically adding a property editor for string capitalization with joiner presets, and refines the string_slice node to use integer types. Review feedback pointed out a bug in the unescaping logic for string separators where the order of replacements could lead to incorrect results, and suggested improvements to the capitalization behavior when word-splitting is disabled to ensure consistency and standard formatting.

cubic-dev-ai

4 issues found across 8 files

Confidence score: 3/5

There is concrete user-impact risk in node-graph/nodes/gcore/src/logic.rs: Unicode case conversion keeps only the first character from to_uppercase()/to_lowercase(), which can produce incorrect text for some characters/locales.
editor/src/messages/portfolio/document/node_graph/node_properties.rs has a UI logic inconsistency where UseJoiner can be hidden when JoinerInput is exposed, and node-graph/nodes/gcore/src/logic.rs also has a use_joiner behavior mismatch for LowerCase/UpperCase; together these are moderate regressions but likely localized.
The PR title format issue in node-graph/nodes/gcore/Cargo.toml is process-related rather than runtime functionality, so it should be fixed but does not by itself indicate breakage.
Pay close attention to node-graph/nodes/gcore/src/logic.rs and editor/src/messages/portfolio/document/node_graph/node_properties.rs - text transformation correctness and joiner control visibility/behavior need validation before merge.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/gcore/Cargo.toml">

<violation number="1" location="node-graph/nodes/gcore/Cargo.toml:31">
P1: Custom agent: **PR title enforcement**

PR title does not follow the required "New nodes" dedicated format. Rename it to `New nodes: 'Name1', 'Name2', and 'Name3'` (with actual node names in single quotes).</violation>
</file>

<file name="editor/src/messages/portfolio/document/node_graph/node_properties.rs">

<violation number="1" location="editor/src/messages/portfolio/document/node_graph/node_properties.rs:1628">
P2: `UseJoiner` control is conditionally hidden when `JoinerInput` is exposed, because both controls are gated on `joiner_value` being non-exposed.</violation>
</file>

<file name="node-graph/nodes/gcore/src/logic.rs">

<violation number="1" location="node-graph/nodes/gcore/src/logic.rs:222">
P2: `use_joiner` is documented as applying to capitalization conversion, but `LowerCase`/`UpperCase` ignore `joiner` when it is enabled.

(Based on your team's feedback about aligning behavior with comments and TODO expectations.) [FEEDBACK_USED]</violation>

<violation number="2" location="node-graph/nodes/gcore/src/logic.rs:234">
P2: Unicode case conversion is lossy here because only the first character of `to_uppercase()`/`to_lowercase()` is kept.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai

3 issues found across 16 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/text/src/lib.rs">

<violation number="1" location="node-graph/nodes/text/src/lib.rs:156">
P3: `first.clone()` is unnecessary — `first` is already an owned `String` and `+` consumes it, reusing its buffer. The clone wastes an allocation.</violation>

<violation number="2" location="node-graph/nodes/text/src/lib.rs:799">
P2: `regex_find` has an empty category `""` while every other regex node uses `"Text: Regex"`. This will cause the node to be miscategorized in the UI.</violation>
</file>

<file name="node-graph/nodes/math/Cargo.toml">

<violation number="1" location="node-graph/nodes/math/Cargo.toml:12">
P1: Custom agent: **PR title enforcement**

PR title violates the PR title rule’s "Special Commit Types → New nodes" format: new-node PRs must be titled as `New node: 'Node Name'` or `New nodes: 'Name1', 'Name2', and 'Name3'`, not `Add new string processing nodes`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

cubic-dev-ai

1 issue found across 3 files (changes from recent commits).

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="node-graph/nodes/text/src/lib.rs">

<violation number="1" location="node-graph/nodes/text/src/lib.rs:296">
P1: When the number is integer-valued (e.g. `0.0`, `1.0`), meaningful precision is 0, so the formatted string has no decimal point. The `None` early-return ignores `extra_zeros` and `fixed_decimals`, producing `"0"` instead of `"0.00"`.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

Keavon · 2026-04-24T03:44:53Z

@cubic-dev-ai

cubic-dev-ai · 2026-04-24T03:45:01Z

@cubic-dev-ai

@Keavon I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

2 issues found across 3 files

Confidence score: 3/5

There are concrete user-facing correctness risks: in node-graph/nodes/text/src/lib.rs, a long suffix can make output exceed the documented max length when keep is floored to 0.
In editor/src/messages/portfolio/document/node_graph/node_properties.rs, UI disabling tied only to use_thousands can incorrectly disable controls when values are graph-driven, which may confuse users and hide valid edits.
The issues are mid-severity (5/10) with strong confidence, so this is mergeable with caution but carries some regression risk in text formatting and node property UX.
Pay close attention to node-graph/nodes/text/src/lib.rs and editor/src/messages/portfolio/document/node_graph/node_properties.rs - length-limit enforcement and dependent-control enable/disable behavior.

Prompt for AI agents (unresolved issues)


Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="editor/src/messages/portfolio/document/node_graph/node_properties.rs">

<violation number="1" location="editor/src/messages/portfolio/document/node_graph/node_properties.rs:1647">
P2: Dependent UI disabling is based on `use_thousands` without handling exposed inputs, so controls can be incorrectly disabled when the value is driven from the graph.</violation>
</file>

<file name="node-graph/nodes/text/src/lib.rs">

<violation number="1" location="node-graph/nodes/text/src/lib.rs:211">
P2: When `suffix` is longer than `length`, the output exceeds the documented maximum. `saturating_sub` silently floors `keep` to 0, but the full suffix is still appended unchecked. Either clamp the suffix to `max_length` graphemes, or skip the suffix entirely when it doesn't fit.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

gemini-code-assist Bot reviewed Apr 5, 2026

View reviewed changes

Comment thread node-graph/nodes/gcore/src/logic.rs Outdated

Comment thread node-graph/nodes/gcore/src/logic.rs Outdated

Comment thread node-graph/nodes/gcore/src/logic.rs Outdated

cubic-dev-ai Bot reviewed Apr 5, 2026

View reviewed changes

Comment thread node-graph/nodes/gcore/Cargo.toml

Comment thread editor/src/messages/portfolio/document/node_graph/node_properties.rs

Comment thread node-graph/nodes/gcore/src/logic.rs Outdated

Comment thread node-graph/nodes/gcore/src/logic.rs Outdated

Keavon force-pushed the string-nodes branch from 085b91f to 950d2a1 Compare April 14, 2026 22:21

cubic-dev-ai Bot reviewed Apr 15, 2026

View reviewed changes

Comment thread node-graph/nodes/math/Cargo.toml

Comment thread node-graph/nodes/text/src/lib.rs Outdated

Comment thread node-graph/nodes/text/src/lib.rs Outdated

Keavon force-pushed the string-nodes branch from 8e0ffd2 to 3650930 Compare April 15, 2026 20:51

Keavon added 19 commits April 23, 2026 14:24

Add new string processing nodes

5ff959f

Remove the IntegerCount = u32 type alias

e92b466

Add the 'Format Number' node

f325590

Add "Up To" parameter to the 'String Pad' node

a0f049b

Fix 'String Capitalization' behavior

d578474

Add 'Map String' and 'Read String' nodes

3774b54

Add separator_escaping to 'String Repeat'

3019c86

Add 'Regex Replace'

9ff88bd

Add 'Regex Match' node

57d171f

Regex Find and Regex Find All

63a01fd

Code review

d93f1c0

Add the 'Escape String' node

7772a2d

Improve implementations

50bc962

Move nodes from logic.rs to text/src/lib.rs

f8a4065

Clean up migrations

3e48b74

Fix #[{hard, soft}_{min, max}(...)] node macro attribute

a7bf8e0

Improve Data panel number and text display

d4b5749

Add the 'Query JSON' and 'Query JSON All' nodes

84b3e2c

Add the 'Lorem Ipsum' node and Ipsum library

653b182

Keavon force-pushed the string-nodes branch from 3650930 to 653b182 Compare April 23, 2026 21:25

Keavon changed the title ~~Add new string processing nodes~~ Add a family of 14 new string processing nodes Apr 24, 2026

Keavon added 2 commits April 23, 2026 20:24

Revert everything to master

468b733

Add the 14 nodes back in their final state

a5d0fce

cubic-dev-ai Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread node-graph/nodes/text/src/lib.rs

github-actions Bot deployed to graphite-dev (Preview) April 24, 2026 03:33 View deployment

Add handling for fixed decimal places in number formatting

897238f

github-actions Bot deployed to graphite-dev (Preview) April 24, 2026 03:49 View deployment

cubic-dev-ai Bot reviewed Apr 24, 2026

View reviewed changes

Comment thread editor/src/messages/portfolio/document/node_graph/node_properties.rs

Comment thread node-graph/nodes/text/src/lib.rs Outdated

Code review fixes

79d2978

github-actions Bot deployed to graphite-dev (Preview) April 24, 2026 05:37 View deployment

Keavon merged commit 6c0af72 into master Apr 24, 2026
11 checks passed

Keavon deleted the string-nodes branch April 24, 2026 05:46

Uh oh!

Conversation

Keavon commented Apr 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Category - Text

Category - Context

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Keavon commented Apr 24, 2026

Uh oh!

cubic-dev-ai Bot commented Apr 24, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Keavon commented Apr 5, 2026 •

edited

Loading